Improve deferred sequence#27
Merged
Merged
Conversation
…n intermediary sequences are not used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For implementation convenience each step of a deferred
Sequenceholds in memory the values generated for its step. This means that the example below will keep in memory the arrays[1, 2, 3, 4],[2, 3, 4, 5]and[4, 6, 8, 10]as long as$sequenceis referenced.This is wasteful as the first 2 arrays can't be accessed from outside the monad and has no purpose inside the monad.
The more a user compose its sequences the more internal copies it holds.
Solution
When composing the generators we use the initial generator if nobody references the
Sequencethat points to the generator.If somebody references the
Sequencewe use theAccumulateiterator as the user may need to iterate over the intermediary values.If the underlying
Generatorhas been started we use theAccumulateiterator as well in order to have access to the first values produced by theGenerator(since aGeneratorcan't be rewinded).